After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765698 - gtk-styles.css: adapt to GTK+ 3.21 CSS strictness
gtk-styles.css: adapt to GTK+ 3.21 CSS strictness
Status: RESOLVED FIXED
Product: gnome-calendar
Classification: Applications
Component: General
unspecified
Other All
: Normal normal
: 3.26
Assigned To: GNOME Calendar maintainers
GNOME Calendar maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-27 22:00 UTC by Marinus Schraal
Modified: 2017-04-17 18:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtk-styles.css: adapt to GTK+ 3.21 CSS strictness (2.47 KB, patch)
2016-04-27 22:00 UTC, Marinus Schraal 		committed Details | Review

Description Marinus Schraal 2016-04-27 22:00:45 UTC 
GTK+ 3.21 is stricter about CSS values having a unit defined. Fix the
gnome-calendar CSS accordingly.
Comment 1 Marinus Schraal 2016-04-27 22:00:49 UTC 
Created attachment 326900 [details] [review]
gtk-styles.css: adapt to GTK+ 3.21 CSS strictness
Comment 2 Georges Basile Stavracas Neto 2016-05-08 14:57:09 UTC 
Review of attachment 326900 [details] [review]:

This patch breaks my Calendar, even when compiling against Gtk+ 3.21. The fonts are much bigger.
Comment 3 Marinus Schraal 2016-05-08 16:10:10 UTC 
That seems odd, can you provide a screenshot.

In essence nothing is changing, besides the css defining the font as being in pt size, which was the default anyway.

If you don't have the patch and you run calendar vs gtk+ 3.21 you should see a lack of styling (weird colors, sizes, etc.), since the incorrect CSS disables all the other styling in a block as well.
Comment 4 Miguel Vaello Martínez 2016-05-09 20:37:07 UTC 
With the last 3.22 dependencies looks good to me.
Comment 5 Georges Basile Stavracas Neto 2016-05-20 14:22:35 UTC 
I was indeed testing it wrongly. The patch does work as expected. Thanks for working on that, and sorry for the trouble.

Attachment 326900 [details] pushed as feedfa4 - gtk-styles.css: adapt to GTK+ 3.21 CSS strictness