After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765552 - Please set serial in .m4 files to prevent autoreconf failure on upgrades
Please set serial in .m4 files to prevent autoreconf failure on upgrades
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: build
2.48.x
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2016-04-25 17:29 UTC by Michael Biebl
Modified: 2017-10-26 11:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Add #serial lines to m4 files (2.27 KB, patch)
2017-10-24 12:07 UTC, Philip Withnall 		committed Details | Review

Description Michael Biebl 2016-04-25 17:29:00 UTC 
Recently, the glib-gettext.m4 was changed upstream.
This leads to failures on autoreconf for packages which already ship an (outdated) copy of glib-gettext.m4. See [1] as an example.

The solution I was pointed at by Simon McVittie, is to use a serial number in the .m4 macro file, so autoreconf knows which one is newer.
See [2] for more details.

Please consider adding a serial number to gsettings.m4, 
glib-gettext.m4 and glib-2.0.m4 to avoid such breakages in the future.



[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=820785
[2] https://www.gnu.org/software/automake/manual/html_node/Serials.html
Comment 1 Philip Withnall 2017-10-24 12:07:40 UTC 
Created attachment 362175 [details] [review]
build: Add #serial lines to m4 files

This helps prevent outdated copies of the m4 files being used if
multiple copies are available in the search path.

See https://www.gnu.org/software/automake/manual/html_node/Serials.html

Signed-off-by: Philip Withnall <withnall@endlessm.com>
Comment 2 Matthias Clasen 2017-10-26 11:10:24 UTC 
Review of attachment 362175 [details] [review]:

ok
Comment 3 Philip Withnall 2017-10-26 11:26:58 UTC 
Attachment 362175 [details] pushed as e130d2e - build: Add #serial lines to m4 files