After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765513 - [PATCH] Adding force aspect ratio support in gstplayer
[PATCH] Adding force aspect ratio support in gstplayer
Status: RESOLVED DUPLICATE of bug 765310
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.8.0
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-25 04:33 UTC by DEEPAK SRIVASTAVA
Modified: 2016-04-25 06:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch file for force-aspect-ratio feature in gstplayer element (4.98 KB, patch)
2016-04-25 04:33 UTC, DEEPAK SRIVASTAVA
needs-work Details | Review

Description DEEPAK SRIVASTAVA 2016-04-25 04:33:01 UTC
Created attachment 326655 [details] [review]
patch file for force-aspect-ratio feature in gstplayer element

Adding force-aspect-ratio-support in gstplayer element.
Added property and getter/setter function for the same.
Comment 1 Sebastian Dröge (slomo) 2016-04-25 06:29:26 UTC
Thanks for taking the time to report this.
This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.

*** This bug has been marked as a duplicate of bug 765310 ***
Comment 2 Sebastian Dröge (slomo) 2016-04-25 06:31:58 UTC
Comment on attachment 326655 [details] [review]
patch file for force-aspect-ratio feature in gstplayer element

Thanks for the patch! Let's continue discussion in the other bug. This is a slightly bigger problem than what you handle in your patch.

From an application point of view you want more than this boolean usually. You usually want to be able to override the aspect ratio, not have it completely loose. The common case is that you have a video that is recorded 4:3 but is actually 16:9 and then want to have this actual aspect ratio enforced by the player. Or even worse, you have that case but also have to crop/zoom in.
Take a look at how totem or VLC are handling this for example.