GNOME Bugzilla – Bug 765502
[PATCH] Tracker fails to autostart when using the system bus
Last modified: 2021-05-26 22:24:31 UTC
Created attachment 326635 [details] [review] Patch fixes autostart on system bus Tracker fails to autostart when using the system bus. This is because the dbus launch helper does not pass the TRACKER_BUS_TYPE through when launching the tracker daemons. It does however set it's own variable (DBUS_STARTER_BUS_TYPE) with the value "system". The attached patch updates the tracker_ipc_bus function to fall back to checking for this variable if TRACKER_BUS_TYPE is not set. The tracker daemon(s) will now start automatically when needed like they do in the session bus.
Relevant part of the dbus code: https://cgit.freedesktop.org/dbus/dbus/tree/bus/activation-helper.c#n161
Review of attachment 326635 [details] [review]: Note that I am not a maintainer, so I can't conclusively ack/nack your patch. From a quick glance, your change looks reasonable to me. However, it would be better if you submitted it in the 'git format-patch' format so that it can be properly attributed and so on. https://wiki.gnome.org/Newcomers/CodeContributionWorkflow has some more details.
tracker-control-general.c manager = tracker_miner_manager_new_full (TRUE, &error); if (!manager) { g_printerr (_("Could not start miners, manager could not be created, %s"), + error ? error->message : _("No error given"));
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new enhancement request ticket at https://gitlab.gnome.org/GNOME/tracker/-/issues/ Thank you for your understanding and your help.