GNOME Bugzilla – Bug 765466
[PATCH] Not calling bindtextdomain causes error messages to become question marks on some locales
Last modified: 2016-05-12 13:25:18 UTC
When running epiphany with zh_TW locale, connecting to https://www.ssllabs.com:10445/ shows the following message: The precise error was: ?? TLS ???????：The Diffie-Hellman prime sent by the server is not acceptable (not long enough). The correct message is: The precise error was: 執行 TLS 交握時發生錯誤：The Diffie-Hellman prime sent by the server is not acceptable (not long enough). Please see the attached patch. It fixes the problem by calling bindtextdomain and bind_textdomain_codeset in g_io_module_load.
Created attachment 326593 [details] [review] proxy, tls: Setup gettext in g_io_module_load(). It is required to properly show error messages on some locales.
Thanks Attachment 326593 [details] pushed as 2634fa5 - proxy, tls: Setup gettext in g_io_module_load().
Created attachment 327678 [details] [review] proxy/gnome: Don't hardcode paths on Windows Use GLib'w Windows APIs to construct the path for the translations dynamically on Windows.
Created attachment 327680 [details] [review] Don't hardcode paths on Windows Use GLib'w Windows APIs to construct the path for the translations dynamically on Windows.
Reopening, please see the patch attached.
Comment on attachment 327680 [details] [review] Don't hardcode paths on Windows >Use GLib'w Windows APIs to construct the path for the translations ^^^ typo other than that, the patch seems fine, but shouldn't there be a helper method for this in glib so we don't need the same boilerplate code everywhere?
yeah... we could have some utility method shared among all modules but that would require all the modules to depend on something common. Apart from that there is really not something generic, see i.e that each project is also defined the global LOCALDIR_DIR variable.
This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.