After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765395 - Theme parsing error: 'gtk-key-bindings' is deprecated
Theme parsing error: 'gtk-key-bindings' is deprecated
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-21 20:51 UTC by John Beard
Modified: 2016-06-19 11:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to evince.css to address the warning (616 bytes, patch)
2016-04-21 20:52 UTC, John Beard 		none Details | Review

Description John Beard 2016-04-21 20:51:27 UTC 
When running up the git master, I get the following error:

Gtk-WARNING **: Theme parsing error: <data>:56:20: The 'gtk-key-bindings' property has been renamed to '-gtk-key-bindings'

Applying the attached patch seems to address it (a simple addition of the "-")
Comment 1 John Beard 2016-04-21 20:52:48 UTC 
Created attachment 326521 [details] [review]
Patch to evince.css to address the warning
Comment 2 Carlos Garcia Campos 2016-05-07 06:38:59 UTC 
Review of attachment 326521 [details] [review]:

Thanks for the patch. Does this work with previous versions of GTK+ too?
Comment 3 John Beard 2016-05-23 20:22:34 UTC 
It would work with versions from 3.19.3 onwards. The commit that introduces the name change is d267b8e028003134c4f7c19545b01a9fefbd2d08.

Would it be better to do a runtime or compile time GTK+ version check in Evince?

What is the normal supported range of GTK versions for Evince?
Comment 4 Carlos Garcia Campos 2016-06-19 11:44:20 UTC 
I've just noticed this bug right after pushing several patches from bug #758793. One of those fixed this with a similar patch. Thank you.