After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765351 - Should use EGL_NO_CONTEXT for EGL_WAYLAND_BUFFER_WL targets
Should use EGL_NO_CONTEXT for EGL_WAYLAND_BUFFER_WL targets
Status: RESOLVED FIXED
Product: cogl
Classification: Platform
Component: Wayland
git master
Other Linux
: Normal normal
: ---
Assigned To: Cogl maintainer(s)
Cogl maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-04-20 21:22 UTC by Sjoerd Simons
Modified: 2016-09-11 00:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1.32 KB, patch)
2016-04-20 21:22 UTC, Sjoerd Simons 		committed Details | Review

Description Sjoerd Simons 2016-04-20 21:22:40 UTC 
Created attachment 326460 [details] [review]
Proposed patch

The spec specifies that eglCreateImage for _WAYLAND_BUFFER_WL targets need to use EGL_NO_CONTEXT as the target. Cogl should follow the spec otherwise some Gl stacks get unhappy with it
Comment 1 Daniel Stone 2016-08-26 15:35:46 UTC 
Please push, as this breaks real actual stacks which are conformant to the letter of the spec.
Comment 2 Emmanuele Bassi (:ebassi) 2016-08-26 15:52:49 UTC 
Review of attachment 326460 [details] [review]:

LGTM.
Comment 3 Daniel Stone 2016-08-26 16:12:31 UTC 
Still no commit bit, and Sjoerd's on holiday. :)
Comment 4 Emmanuele Bassi (:ebassi) 2016-08-26 16:27:28 UTC 
Attachment 326460 [details] pushed to the cogl-1.22 branch.
Comment 5 Jeremy Bicha 2016-09-11 00:33:14 UTC 
This commit causes a build failure when cogl is built without wayland (Debian does this for its kfreebsd platform which uses a BSD kernel)

https://bugzilla.gnome.org/show_bug.cgi?id=770533/