GNOME Bugzilla – Bug 765266
gl: More GLES/GL 3 compatibility fixes
Last modified: 2016-08-31 10:28:05 UTC
Commit 822f09f6aeaee2202104bbb7dc2ac7b5a299c252 was not complete yet, see attached patches. The first one definitely works and is required to use glimagesink on Android now... the second is untested. Additionally gloverlaycomposition, glcolorbalance and many others also seem to need similar changes.
Created attachment 326340 [details] [review] glcolorconvert: GLES3 deprecates texture2D() and it does not work at all in newer versions than 3.3 Use the newer texture() function instead. This fixes glimagesink and other things on various Android devices.
Created attachment 326341 [details] [review] glviewconvert: Port more things to GLES/GL 3 compatibility And move the shader mangling code into a single place instead of having a copy in glcolorconvert and glviewconvert.
Created attachment 326383 [details] [review] glviewconvert: Port more things to GLES/GL 3 compatibility And move the shader mangling code into a single place instead of having a copy in glcolorconvert and glviewconvert.
*** Bug 765517 has been marked as a duplicate of this bug. ***
Review of attachment 326383 [details] [review]: Looks ok.
Attachment 326340 [details] pushed as 57a4494 - glcolorconvert: GLES3 deprecates texture2D() and it does not work at all in newer versions than 3.3 Attachment 326383 [details] pushed as b9cfa34 - glviewconvert: Port more things to GLES/GL 3 compatibility
That now leaves glcolorbalance, gloverlaycomposition and probably others that need to be ported. Correct?
Correct.
This seems to have caused a regression for android zerocopy. See bug 767022
You mean https://bugzilla.gnome.org/show_bug.cgi?id=766993
And it's bug 766993
I noticed that we include gl3ext.h here https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst-libs/gst/gl/gstglapi.h#n44 . We should include gl2ext.h since gl3ext.h is empty. See https://www.khronos.org/registry/gles/ and https://cgit.freedesktop.org/mesa/mesa/tree/include/GLES3/gl3ext.h
(In reply to Sebastian Dröge (slomo) from comment #7) > That now leaves glcolorbalance, gloverlaycomposition and probably others > that need to be ported. Correct? Actually, these all use gles2 shaders where texture2D is fine to use so there's no bug here anymore.