After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765225 - [review] [libnm] allow specifying VPN plugin without path in .name file [th/vpn-load-plugin-bgo765225]
[review] [libnm] allow specifying VPN plugin without path in .name file [th/v...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-1-2
 
 
Reported: 2016-04-18 16:49 UTC by Thomas Haller
Modified: 2016-04-19 13:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Haller 2016-04-18 16:49:13 UTC 
To support multiarch, distributions should not put the absolute path to the .name file of VPN plugins. Relax the checks in libnm to allow specifying the plugin without path.

I still think, that for a user building from source, it is preferable to encode the absolute paths there (and note, that all plugins -- both libnm and libnm-glib -- specify absolute paths).


Anyway, remove the restriction from libnm, so that distributions are able to do the right thing for multiarch.
Comment 1 Lubomir Rintel 2016-04-19 10:12:35 UTC 
Looks good
Comment 2 Beniamino Galvani 2016-04-19 11:26:10 UTC 
LGTM too.