GNOME Bugzilla – Bug 765218
schemas: Add mouse accel profile key
Last modified: 2016-07-28 07:22:44 UTC
Users seems to want to disable pointer acceleration for mouse devices. This is be needed to fix bug 763293. We should also consider adding the same setting for touchpads and trackpoints.
Created attachment 326265 [details] [review] schemas: Add mouse accel profile key Add an entry for configuring the acceleration profile for mouse devices. This is intended to be mapped to the libinput acceleration profile configuration API.
Review of attachment 326265 [details] [review]: ::: headers/gdesktop-enums.h @@ +82,3 @@ + G_DESKTOP_MOUSE_ACCEL_PROFILE_FLAT, + G_DESKTOP_MOUSE_ACCEL_PROFILE_ADAPTIVE +} GDesktopMouseAccelProfile; Can we use a string instead, so that we don't need to update this when libinput has a new acceleration profile?
(In reply to Bastien Nocera from comment #2) > Review of attachment 326265 [details] [review] [review]: > > ::: headers/gdesktop-enums.h > @@ +82,3 @@ > + G_DESKTOP_MOUSE_ACCEL_PROFILE_FLAT, > + G_DESKTOP_MOUSE_ACCEL_PROFILE_ADAPTIVE > +} GDesktopMouseAccelProfile; > > Can we use a string instead, so that we don't need to update this when > libinput has a new acceleration profile? We could, but I both also don't see libinput adding any accel profiles very often, so not sure the benefit is worth the error-prone:ness of a string.
(In reply to Jonas Ådahl from comment #3) > (In reply to Bastien Nocera from comment #2) > > Review of attachment 326265 [details] [review] [review] [review]: > > > > ::: headers/gdesktop-enums.h > > @@ +82,3 @@ > > + G_DESKTOP_MOUSE_ACCEL_PROFILE_FLAT, > > + G_DESKTOP_MOUSE_ACCEL_PROFILE_ADAPTIVE > > +} GDesktopMouseAccelProfile; > > > > Can we use a string instead, so that we don't need to update this when > > libinput has a new acceleration profile? > > We could, but I both also don't see libinput adding any accel profiles very > often, so not sure the benefit is worth the error-prone:ness of a string. Future proofing.... In any case, if you're happy with using an enum, sure. Only thing I'd do is rename the *mouse* accel profile to *pointer* accel profile, and add the configuration for mouse, trackball, etc. right now. No need to delay that as we're going to get asked anyway.
(In reply to Bastien Nocera from comment #4) > (In reply to Jonas Ådahl from comment #3) > > (In reply to Bastien Nocera from comment #2) > > > Review of attachment 326265 [details] [review] [review] [review] [review]: > > > > > > ::: headers/gdesktop-enums.h > > > @@ +82,3 @@ > > > + G_DESKTOP_MOUSE_ACCEL_PROFILE_FLAT, > > > + G_DESKTOP_MOUSE_ACCEL_PROFILE_ADAPTIVE > > > +} GDesktopMouseAccelProfile; > > > > > > Can we use a string instead, so that we don't need to update this when > > > libinput has a new acceleration profile? > > > > We could, but I both also don't see libinput adding any accel profiles very > > often, so not sure the benefit is worth the error-prone:ness of a string. > > Future proofing.... > > In any case, if you're happy with using an enum, sure. Only thing I'd do is > rename the *mouse* accel profile to *pointer* accel profile, and add the > configuration for mouse, trackball, etc. right now. No need to delay that as > we're going to get asked anyway. We'd need to update mutter source code anyway, so adding a value to this entry is just marginally more work. Fair point with renaming and adding trackball and touchpad keys. Will update.
Created attachment 332129 [details] [review] schemas: Add mouse and trackball accel profile keys Add an entry for configuring the acceleration profile for mouse and trackball devices. This is intended to be mapped to the libinput acceleration profile configuration API.
Review of attachment 332129 [details] [review]: Sure.
Attachment 332129 [details] pushed as 9a7e6d3 - schemas: Add mouse and trackball accel profile keys