After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764781 - no g_simple_async_result_set_check_cancellable call in the generated code
no g_simple_async_result_set_check_cancellable call in the generated code
Status: RESOLVED DUPLICATE of bug 763345
Product: vala
Classification: Core
Component: Code Generator
unspecified
Other All
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks: 763908
 
 
Reported: 2016-04-08 13:39 UTC by Rafael Fonseca
Modified: 2017-01-22 12:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Rafael Fonseca 2016-04-08 13:39:26 UTC 
Without calling said function, there might be a race condition between the check and when the callback is called.

An example of such "racy" generated code is tracker (tracker-direct.c).
Comment 1 Debarshi Ray 2017-01-22 12:15:26 UTC 
Carlos ported Vala's code generator to use GTask instead of GSimpleAsync result. GTask-using code doesn't have this problem because it checks the GCancellable by default. Also, GTask has been around for a long enough time, that nobody should need to GSimpleAsyncResult any more.

*** This bug has been marked as a duplicate of bug 763345 ***