GNOME Bugzilla – Bug 764712
Build failure for Quartz backend in master branch due to gtkdnd-quartz.c (_gtkDragDestSite already defined)
Last modified: 2016-04-24 10:51:43 UTC
The master branch on commit 6628ffd686859f7170ea6b (wayland: Check the tablet manager before creating a wp_tablet_seat) on April 6th 2016 fails to build in Quartz configuration with the following error messages during build: /Applications/Xcode.app/Contents/Developer/usr/bin/make all-am CC libgtk_3_la-gtkdnd-quartz.lo gtkdnd-quartz.c:85:8: error: redefinition of '_GtkDragDestSite' struct _GtkDragDestSite ^ ./gtkdndprivate.h:30:8: note: previous definition is here struct _GtkDragDestSite I build this in the macports environment in MacOS with the following configure setup ./configure --disable-x11-backend --enable-quartz-backend --enable-debug=yes LDFLAGS=-L/opt/local/lib CPPFLAGS=-I/opt/local/include --prefix=/Users/fritz/pspp/install The build works for me in the gtk-3-20 branch. Friedrich
Due to https://git.gnome.org/browse/gtk+/commit/gtk/gtkdndprivate.h?id=6ac7b54378ad1a8468df889744321bd61ab9e565 which moved the definition from gtkdnd.c to gtkdndprivate.h without also removing it from gtkdnd-quartz.c.
The real goal here is still to get rid of gtkdnd-quartz.c and have a single source for this. In the meantime, I would appreciate a patch to fix this (no os x here...)
Created attachment 326628 [details] [review] fix dnd on quartz broke out the osx laptop today to test recent perf changes, came across this too.
Review of attachment 326628 [details] [review]: ACK.
Let me know if you have any more issues building and I'll take a look. There were certainly some warnings that should be cleaned up too. We seem to rely on C11 without specifying -std=c11 and also some unused variables.