After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764503 - Mouse panel listbox rows are activatable
Mouse panel listbox rows are activatable
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Mouse
git master
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-02 16:21 UTC by Timm Bäder
Modified: 2016-04-06 09:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
mouse panel: Make all listbox rows unactivatable (5.13 KB, patch)
2016-04-02 16:21 UTC, Timm Bäder 		committed Details | Review
mouse panel: Remove superfluous GtkListBoxRow (33.93 KB, patch)
2016-04-02 16:21 UTC, Timm Bäder 		committed Details | Review

Description Timm Bäder 2016-04-02 16:21:18 UTC 
Created attachment 325225 [details] [review]
mouse panel: Make all listbox rows unactivatable

I.e. they have a hover+active state even though clicking them doesn't do anything.

I'll attach another unrelated patch because I don't want to open another bug for it :)
Comment 1 Timm Bäder 2016-04-02 16:21:58 UTC 
Created attachment 325226 [details] [review]
mouse panel: Remove superfluous GtkListBoxRow
Comment 2 Felipe Borges 2016-04-04 12:49:48 UTC 
Review of attachment 325225 [details] [review]:

sure. makes sense.
Comment 3 Felipe Borges 2016-04-04 12:50:54 UTC 
Review of attachment 325226 [details] [review]:

Yep. This was because in the previous implementation we were hiding the whole bunch (GtkListBox inside of the row). Now we just change the sensitivity.
Comment 4 Felipe Borges 2016-04-04 12:51:46 UTC 
I didn't change the statuses of the patches because I'm not maintainer of gnome-control-center. I'd rather let the maintainers decide.
Comment 5 Felipe Borges 2016-04-06 09:01:08 UTC 
Thanks for your patches. Pushed to master as 9a43229ec2867f122ae51da943519cdbbb0649e6 and 645330853b4480c548e8e0cf04bc8a4022ee5df9