After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764474 - [review] refactor writing state file by moving from NMManager to NMConfig [th/run-state-to-nm-config-bgo764474]
[review] refactor writing state file by moving from NMManager to NMConfig [th...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-04-01 18:35 UTC by Thomas Haller
Modified: 2016-04-07 08:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Haller 2016-04-01 18:35:31 UTC 
Currently, our statefile is quite sparse:

cat /var/lib/NetworkManager/NetworkManager.state
[main]
NetworkingEnabled=true
WirelessEnabled=true
WWANEnabled=true


But for bug 746440, we will need to store more state, including per-device-state.

Move the handling of the run-state file to NMConfig to NMManager. It will fit there well.


Please review.
Comment 1 Beniamino Galvani 2016-04-07 07:38:03 UTC 
LGTM (pushed trivial fixup)
Comment 2 Thomas Haller 2016-04-07 08:17:17 UTC 
Thanks. Merged to master: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=1b43c880ba43260fe551b0ac923826f16737484f


(now, I think for bug 746440 we will not store device state to /var/lib, but instead /run. Thus, the original motivation for this patch is no longer there. I still like it though and thus it got merged).