After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764297 - search: force GTK_ICON_SIZE_DIALOG icon size
search: force GTK_ICON_SIZE_DIALOG icon size
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Search
unspecified
Other All
: Normal normal
: ---
Assigned To: Cosimo Cecchi
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-03-29 00:59 UTC by Cosimo Cecchi
Modified: 2016-04-21 07:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
search: force GTK_ICON_SIZE_DIALOG icon size (1.24 KB, patch)
2016-03-29 00:59 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2016-03-29 00:59:32 UTC 
Since some applications don't ship icons in all sizes
Comment 1 Cosimo Cecchi 2016-03-29 00:59:36 UTC 
Created attachment 324910 [details] [review]
search: force GTK_ICON_SIZE_DIALOG icon size

Force a pizel size too, so that we can work around applications not
shipping icons at all sizes.

[endlessm/eos-shell#2756]
Comment 2 Bastien Nocera 2016-04-15 09:50:20 UTC 
Review of attachment 324910 [details] [review]:

> [endlessm/eos-shell#2756]

Use a URL if this is publicly accessible, otherwise remove it.

Looks good otherwise, for gnome-3-20 and master.

::: panels/search/cc-search-panel.c
@@ +465,2 @@
   w = gtk_image_new_from_gicon (icon, GTK_ICON_SIZE_DIALOG);
+  if (gtk_icon_size_lookup (GTK_ICON_SIZE_DIALOG, &width, &height))

I don't think this can fail if you don't pass garbage to it, so no need for the check.
Comment 3 Cosimo Cecchi 2016-04-21 07:07:03 UTC 
Thanks, pushed with those fixes.