After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763965 - qtdemux: Modify data type of duration in handle_src_query function
qtdemux: Modify data type of duration in handle_src_query function
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-03-21 01:29 UTC by Jimmy Ohn
Modified: 2016-03-24 12:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
qtdemux: Modity data type of duration in handle_src_query function (1.00 KB, patch)
2016-03-21 01:32 UTC, Jimmy Ohn 		committed Details | Review

Description Jimmy Ohn 2016-03-21 01:29:53 UTC 
Data type of duration need to mofidy from guint64 to GHstClockTime in handle_src_query function. As I know, GstClockTime is same guint64. But, I think that It should be modify from guint64 to GstClockTime for consistency.
Comment 1 Jimmy Ohn 2016-03-21 01:32:43 UTC 
Created attachment 324404 [details] [review]
qtdemux: Modity data type of duration in handle_src_query function
Comment 2 Sebastian Dröge (slomo) 2016-03-21 08:41:23 UTC 
Comment on attachment 324404 [details] [review]
qtdemux: Modity data type of duration in handle_src_query function

They're exactly the same, yes.
Comment 3 Jimmy Ohn 2016-03-21 08:44:02 UTC 
(In reply to Sebastian Dröge (slomo) from comment #2)
> Comment on attachment 324404 [details] [review] [review]
> qtdemux: Modity data type of duration in handle_src_query function
> 
> They're exactly the same, yes.

@slomo
I have a question. If I upload some patches through the github without bugzilla, is it ok?
Comment 4 Sebastian Dröge (slomo) 2016-03-21 09:01:56 UTC 
No
Comment 5 Sebastian Dröge (slomo) 2016-03-24 12:37:17 UTC 
commit 0ef9e6d1390e2ea81ad1521e896697f742b05def
Author: Jimmy Ohn <yongjin.ohn@lge.com>
Date:   Mon Mar 21 10:11:23 2016 +0900

    qtdemux: Modify data type of duration in handle_src_query function
    
    Data type of duration need to modify from guint64 to GstClockTime
    for consistency in handle_src_query function.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=763965