After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763913 - GDK W32: Not all relevant debug info is printed for events
GDK W32: Not all relevant debug info is printed for events
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Win32
unspecified
Other All
: Low enhancement
: ---
Assigned To: gtk-win32 maintainers
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-03-19 12:12 UTC by LRN
Modified: 2016-03-25 22:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GDK W32: Print more debug info about events (1.58 KB, patch)
2016-03-19 12:12 UTC, LRN 		committed Details | Review
GDK W32: Print error code along with the error message (1.38 KB, patch)
2016-03-25 20:34 UTC, LRN 		committed Details | Review

Description LRN 2016-03-19 12:12:12 UTC 
Specifically, of interest are event timestamps and wParam/lParam values
for messages (especially for unknown messages).
Comment 1 LRN 2016-03-19 12:12:18 UTC 
Created attachment 324333 [details] [review]
GDK W32: Print more debug info about events

1) Print timestamps for events
2) Print wParam and lParam (in hex form) for messages
Comment 2 Ignacio Casal Quinteiro (nacho) 2016-03-19 12:15:02 UTC 
Review of attachment 324333 [details] [review]:

Fine for me
Comment 3 LRN 2016-03-19 12:16:18 UTC 
I'll wait for fanc to test it. Specifically, the %lx format specifier. I'm not sure what's the status of "l" support in MSVC.
Comment 4 Fan, Chun-wei 2016-03-19 14:35:02 UTC 
Hi LRN,

As far as I could tell, the format specifier is correct.

With blessings, thank you!
Comment 5 LRN 2016-03-25 20:34:18 UTC 
Created attachment 324769 [details] [review]
GDK W32: Print error code along with the error message

An extra debug enhancement that alters _gdk_win32_api_failed()
(used internally by a number of error-checking macros) to print
the error code along with he error message.

I thought about filing it separately, but this bug's description
fits, so why not attach it here?

This addresses concerns raised in bug 763907 about the message/code dichotomy.
Comment 6 Ignacio Casal Quinteiro (nacho) 2016-03-25 21:31:31 UTC 
Review of attachment 324769 [details] [review]:

Fine for me.
Comment 7 LRN 2016-03-25 22:10:33 UTC 
Attachment 324333 [details] pushed as c4c0029 - GDK W32: Print more debug info about events
Attachment 324769 [details] pushed as 692c3b1 - GDK W32: Print error code along with the error message