After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763881 - edit-palette-row: Don't leak the PhotosTool
edit-palette-row: Don't leak the PhotosTool
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-03-18 16:18 UTC by Rafael Fonseca
Modified: 2016-04-28 19:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix leak of tool reference (907 bytes, patch)
2016-03-18 16:18 UTC, Rafael Fonseca 		committed Details | Review

Description Rafael Fonseca 2016-03-18 16:18:46 UTC 
Created attachment 324288 [details] [review]
Fix leak of tool reference

If the tool is never disposed, some tools like filters, which hold a reference to BaseItem, might cause a whole chain of leaked objects (BaseItem -> ViewModel -> controllers -> ...).

The attached patch makes sure we release the reference to the tool object.
Comment 1 Debarshi Ray 2016-03-18 17:18:34 UTC 
Review of attachment 324288 [details] [review]:

Good catch. EditPaletteRow owns a reference to the tool, so it should unref it during destruction.

Committed after adding the URL to the bug.