After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763843 - [PATCH] Segmentation fault when setting filter colors.
[PATCH] Segmentation fault when setting filter colors.
Status: RESOLVED FIXED
Product: gnome-system-log
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-system-log-maint
gnome-system-log-maint
Depends on:
Blocks:
 
 
Reported: 2016-03-18 00:45 UTC by sipertruk
Modified: 2016-03-19 20:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for "Segmentation fault when setting filter colors." (5.55 KB, patch)
2016-03-18 00:45 UTC, sipertruk 		none Details | Review
Fix for last commit (3.82 KB, patch)
2016-03-19 04:34 UTC, sipertruk 		needs-work Details | Review

Description sipertruk 2016-03-18 00:45:39 UTC 
Created attachment 324221 [details] [review]
Patch for "Segmentation fault when setting filter colors."

A previous commit only half-switched from deprecated GdkColor to GdkRGBA. This patch complete the switch.
Comment 1 Cosimo Cecchi 2016-03-18 17:50:48 UTC 
Thanks for the patch; I pushed a slightly different version that does not change the properties being used (your patch changed paragaph-background to background).
Comment 2 sipertruk 2016-03-19 04:34:59 UTC 
Created attachment 324314 [details] [review]
Fix for last commit
Comment 3 sipertruk 2016-03-19 04:36:38 UTC 
I attached a little fix, a few paragraph-background* were forgotten in logview-manager.c.
Comment 4 Cosimo Cecchi 2016-03-19 17:07:31 UTC 
Comment on attachment 324314 [details] [review]
Fix for last commit

This patch does not seem to apply
Comment 5 sipertruk 2016-03-19 20:08:08 UTC 
I was looking at the wrong branch.