After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763793 - h264parse, h265parse: failure to parse downstream force-key-unit event
h264parse, h265parse: failure to parse downstream force-key-unit event
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.x
Other Linux
: Normal normal
: 1.6.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
1.6.4
Depends on:
Blocks:
 
 
Reported: 2016-03-17 08:12 UTC by Aleksander Wabik
Modified: 2016-04-14 17:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
The fix (1.55 KB, patch)
2016-03-17 08:12 UTC, Aleksander Wabik 		committed Details | Review

Description Aleksander Wabik 2016-03-17 08:12:20 UTC 
The parser handles the downstream force-key-unit event incorrectly, it tries to parse it as an upstream force-key-unit event, does not check the return value, and then uses uninitialized memory in "all_headers" boolean variable.
Comment 1 Aleksander Wabik 2016-03-17 08:12:44 UTC 
Created attachment 324155 [details] [review]
The fix
Comment 2 Tim-Philipp Müller 2016-03-17 19:32:28 UTC 
commit d8e681bb6317e1c26ca522e15836d13a6d9b14cb
Author: Aleksander Wabik <awabik@opera.com>
Date:   Thu Mar 17 19:24:32 2016 +0000

    h264parse, h265parse: fix handling of downstream force-key-unit events
    
    The parser handles the downstream force-key-unit event incorrectly,
    it tries to parse it as an upstream force-key-unit event, does not
    check the return value, and then uses uninitialized memory in
    "all_headers" boolean variable.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=763793