After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763774 - [HighContrast(|Inverse)] GtkPlacesSidebar row need more top&bottom padding
[HighContrast(|Inverse)] GtkPlacesSidebar row need more top&bottom padding
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
3.19.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-03-16 18:24 UTC by Arnaud B.
Modified: 2016-03-20 21:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot. (39.55 KB, image/png)
2016-03-16 18:24 UTC, Arnaud B. 		  Details
High Contrast: sidebar round buttons (60.07 KB, patch)
2016-03-20 21:08 UTC, Jakub Steiner 		committed Details | Review

Description Arnaud B. 2016-03-16 18:24:27 UTC 
Created attachment 324126 [details]
Screenshot.

When using HighContrast/HighContrastInverse themes, the GtkPlacesSidebar looks “compressed” vertically; the rows probably need more top&bottom padding.
Comment 1 Matthias Clasen 2016-03-17 01:45:59 UTC 
I think the main problem here is the big eject buttons
Comment 2 Lapo Calamandrei 2016-03-17 17:14:38 UTC 
yup, the button is the problem there, it gets shrinked in adwaita indeed, relevant code from adwaita: 

button.sidebar-button {
  @extend %button_basic.flat;

  @extend %button_selected.flat;

  min-height: 26px;
  min-width: 26px;
  margin-top: 3px;
  margin-bottom: 3px;
  padding: 0;
  border-radius: 100%;
  -gtk-outline-radius: 100%;

  &:not(:hover):not(:active),
  &:backdrop { > image { opacity: $_placesidebar_icons_opacity; }}
}
Comment 3 Jakub Steiner 2016-03-20 21:08:33 UTC 
Created attachment 324389 [details] [review]
High Contrast: sidebar round buttons
Comment 4 Jakub Steiner 2016-03-20 21:09:17 UTC 
Attachment 324389 [details] pushed as 7224dd7 - High Contrast: sidebar round buttons