After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763650 - window: stop stomping on resize-mode set by external API
window: stop stomping on resize-mode set by external API
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
: 762513 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-03-14 22:54 UTC by Cosimo Cecchi
Modified: 2016-03-24 13:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
window: stop stomping on resize-mode set by external API (5.41 KB, patch)
2016-03-14 22:54 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2016-03-14 22:54:19 UTC 
See attached patch
Comment 1 Cosimo Cecchi 2016-03-14 22:54:22 UTC 
Created attachment 323934 [details] [review]
window: stop stomping on resize-mode set by external API

commit c3dc0d80f1353ac66882ca3288ca7e9a13c47d6f fixed the behavior of
GtkContainer widgets requesting an IMMEDIATE resize-mode.

However, GtkWindow has been stomping on resize-mode during realize()
since commit addcc64b9cbb2fb1225080075ad3112a3d93d839. The combination
of factors that led to this not being a visible problem during all this
while is uncertain, but this now causes the Shell to continuously try to
relayout its ShellEmbeddedWindow (a GtkWindow subclass).

This commit separates the resize-mode as set internally by GtkWindow
from the one set with the external API, so that GtkWindow only changes
it when it had not been set before by the subclass.
Comment 2 Cosimo Cecchi 2016-03-14 23:13:11 UTC 
Attachment 323934 [details] pushed as d61c2b4 - window: stop stomping on resize-mode set by external API

ACKed by Company on IRC.
I will open another issue to clean this up after we branch for 3.20.
Comment 3 Olivier Fourdan 2016-03-24 13:17:57 UTC 
*** Bug 762513 has been marked as a duplicate of this bug. ***