After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763602 - validate: Fix overflow seek position comparision
validate: Fix overflow seek position comparision
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-devtools
unspecified
Other All
: Normal blocker
: 1.7.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-03-14 11:02 UTC by Sebastian Dröge (slomo)
Modified: 2016-03-14 12:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
validate: Fix overflow seek position comparision (2.57 KB, patch)
2016-03-14 11:02 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2016-03-14 11:02:06 UTC 
See commit message
Comment 1 Sebastian Dröge (slomo) 2016-03-14 11:02:10 UTC 
Created attachment 323848 [details] [review]
validate: Fix overflow seek position comparision

MAX(0, ((gint64) priv->segment_start - priv->seek_pos_tol) will be a high
positive number thanks to being interpreted as unsigned values if
segment_start < seek_pos_tol. Fix this by explicitly checking for this case
and only doing the subtraction otherwise.

This fixes the problem from fdccffbb2e5885b3f8e7369cdbda45b6717ffab0
completely now.
Comment 2 Sebastian Dröge (slomo) 2016-03-14 12:17:59 UTC 
Attachment 323848 [details] pushed as 3f0a13d - validate: Fix overflow seek position comparision