After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763362 - vaapidisplay: Fix uninitialized value error for VA attribute
vaapidisplay: Fix uninitialized value error for VA attribute
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-03-09 05:15 UTC by Vineeth
Modified: 2016-03-09 17:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix uninitialized values error (898 bytes, patch)
2016-03-09 05:15 UTC, Vineeth 		none Details | Review
Fix uninitialized values error (1.18 KB, patch)
2016-03-09 08:12 UTC, Vineeth 		committed Details | Review

Description Vineeth 2016-03-09 05:15:06 UTC 
Fix for the below issue

==20760== Conditional jump or move depends on uninitialised value(s)
==20760==    at 0x666C059: get_render_mode_VADisplayAttribRenderMode (gstvaapidisplay.c:1837)
==20760==    by 0x666C059: gst_vaapi_display_get_render_mode (gstvaapidisplay.c:1912)
==20760==    by 0x664B9A8: gst_vaapisink_display_changed (gstvaapisink.c:1179)
==20760==    by 0x6643EE4: gst_vaapi_plugin_base_ensure_display (gstvaapipluginbase.c:347)
==20760==    by 0x664A0DB: gst_vaapisink_ensure_display (gstvaapisink.c:160)
==20760==    by 0x664A0DB: gst_vaapisink_set_bus (gstvaapisink.c:1628)
==20760==    by 0x408BFCE: gst_element_set_bus (gstelement.c:3068)
==20760==    by 0x405FC48: gst_bin_add_func (gstbin.c:1160)
==20760==    by 0x4064C77: gst_bin_add (gstbin.c:1374)
==20760==    by 0x4102839: priv_gst_parse_launch (grammar.y:1115)
==20760==    by 0x40F8C2E: gst_parse_launch_full (gstparse.c:325)
==20760==    by 0x40F8EA9: gst_parse_launchv_full (gstparse.c:262)
==20760==    by 0x40F8FA2: gst_parse_launchv (gstparse.c:215)
==20760==    by 0x804A6EA: main (gst-launch.c:998)
Comment 1 Vineeth 2016-03-09 05:15:48 UTC 
Created attachment 323472 [details] [review]
Fix uninitialized values error
Comment 2 Sebastian Dröge (slomo) 2016-03-09 06:56:34 UTC 
Comment on attachment 323472 [details] [review]
Fix uninitialized values error

Maybe like all other of these structs it should be memset to 0 before filling it with values and passing it to any libva API?
Comment 3 Vineeth 2016-03-09 08:12:49 UTC 
Created attachment 323480 [details] [review]
Fix uninitialized values error

initializing the whole attributes to 0 before assigning the values.
Not sure if we have to the same for all other structures as well.