After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763180 - use the right libical tzid handling function
use the right libical tzid handling function
Status: RESOLVED FIXED
Product: gnome-calendar
Classification: Applications
Component: General
3.19.x
Other Linux
: Normal normal
: 3.26
Assigned To: GNOME Calendar maintainers
GNOME Calendar maintainers
Depends on:
Blocks:
 
 
Reported: 2016-03-06 19:50 UTC by Marinus Schraal
Modified: 2017-04-17 18:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix tzid usage (1.29 KB, patch)
2016-03-06 19:50 UTC, Marinus Schraal 		committed Details | Review

Description Marinus Schraal 2016-03-06 19:50:01 UTC 
Created attachment 323206 [details] [review]
fix tzid usage

Depending on where libical sources it's tzid, it may contain it's prefix or not. Use the right function in libical to get a valid timezone offset, otherwise we get UTC shifted events once more.

eg. gmail calendars provide tzid = Europe/Amsterdam , while new events provide tzid = /freeassociation.sourceforge.net/Europe/Amsterdam .

Another solution might be to actually make sure we always get the one or the other from ECalComponentDateTime->tzid . But I'm not 100% sure how eds/ical handles this, if it just gets the one it finds in the .ics (which is going to be in the regular form for eg. gmail) or if it actually always transforms it before it gets provided to its own format.
Comment 1 Georges Basile Stavracas Neto 2016-03-06 20:09:30 UTC 
Thanks for the patch.