After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763178 - Name doesn't update in connection popover
Name doesn't update in connection popover
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
3.19.x
Other Linux
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2016-03-06 15:55 UTC by Florian Müllner
Modified: 2016-03-31 16:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
roomList: update room name in pop-over when room name changes (916 bytes, patch)
2016-03-21 00:22 UTC, Sankaranarayanan Viswanathan 		committed Details | Review

Description Florian Müllner 2016-03-06 15:55:23 UTC 
The connection popover of room list headers uses the account name ("GNOME (irc.gnome.org)"), but doesn't update when the name changes (only on connection status changes).
Comment 1 Sankaranarayanan Viswanathan 2016-03-20 22:54:40 UTC 
(In reply to Florian Müllner from comment #0)
> The connection popover of room list headers uses the account name ("GNOME
> (irc.gnome.org)"), but doesn't update when the name changes (only on
> connection status changes).

Hi Florian,

I'm not sure how to recreate the issue.

When I navigate to Polari menu -> Connections and edit the "Description" of a connection in the "Edit Connection" settings popup, the new description shows on the header of the room list for that connection. I also tried navigating to the "+ button" -> "Join a Room" popup, and the updated description shows up on the connection pull down button as well.

Could you provide any additional information/steps to recreate the behavior you noticed?

Thanks,
Sankar
Comment 2 Sankaranarayanan Viswanathan 2016-03-20 23:06:01 UTC 
(In reply to Sankaranarayanan Viswanathan from comment #1)
> (In reply to Florian Müllner from comment #0)
> > The connection popover of room list headers uses the account name ("GNOME
> > (irc.gnome.org)"), but doesn't update when the name changes (only on
> > connection status changes).
> 
> Hi Florian,
> 
> I'm not sure how to recreate the issue.
> 
> When I navigate to Polari menu -> Connections and edit the "Description" of
> a connection in the "Edit Connection" settings popup, the new description
> shows on the header of the room list for that connection. I also tried
> navigating to the "+ button" -> "Join a Room" popup, and the updated
> description shows up on the connection pull down button as well.
> 
> Could you provide any additional information/steps to recreate the behavior
> you noticed?
> 
> Thanks,
> Sankar

Please ignore my question. I was testing using the default Polari version shipped in Debian and not the latest build.
Comment 3 Sankaranarayanan Viswanathan 2016-03-21 00:22:39 UTC 
Created attachment 324399 [details] [review]
roomList: update room name in pop-over when room name changes

Modify onDisplayNameChanged to invoke onConnectionStatusChanged
so that the pop-over status label is refreshed.
Comment 4 Florian Müllner 2016-03-23 16:50:14 UTC 
Review of attachment 324399 [details] [review]:

OK
Comment 5 Florian Müllner 2016-03-31 16:55:18 UTC 
Attachment 324399 [details] pushed as 44014f5 - roomList: update room name in pop-over when room name changes