After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763059 - opusdec: plug caps leak
opusdec: plug caps leak
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal blocker
: 1.7.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-03-03 19:44 UTC by Håvard Graff (hgr)
Modified: 2016-03-11 15:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (760 bytes, patch)
2016-03-03 19:44 UTC, Håvard Graff (hgr) 		needs-work Details | Review

Description Håvard Graff (hgr) 2016-03-03 19:44:02 UTC 
Created attachment 323019 [details] [review]
patch

Just avoid doing the copy.
Comment 1 Håvard Graff (hgr) 2016-03-03 19:45:01 UTC 
We found this running the test here: https://bugzilla.gnome.org/show_bug.cgi?id=763058 locally
Comment 2 Tim-Philipp Müller 2016-03-03 19:59:29 UTC 
Comment on attachment 323019 [details] [review]
patch

Thanks, I don't think this is entirely correct though.

The code here might modify the caps via the gst_structure_set_value() in the loop, and we have no guarantee that we are allowed to modify these caps here.

I think the right solution is to use caps = gst_caps_make_writable (caps) here.
Comment 3 Tim-Philipp Müller 2016-03-03 20:26:14 UTC 
commit 461cdd8c266c85a008ea0a8ab934a9a2487e5567
Author: Havard Graff <havard.graff@gmail.com>
Date:   Thu Mar 3 20:10:17 2016 +0100

    opusdec: plug caps leak
    
    https://bugzilla.gnome.org/show_bug.cgi?id=763059