After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763058 - opusdec: add unit test for PLC timestamp when FEC is enabled
opusdec: add unit test for PLC timestamp when FEC is enabled
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal enhancement
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 764631
Blocks:
 
 
Reported: 2016-03-03 19:42 UTC by Håvard Graff (hgr)
Modified: 2016-06-17 08:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
test (3.53 KB, patch)
2016-03-03 19:42 UTC, Håvard Graff (hgr) 		committed Details | Review

Description Håvard Graff (hgr) 2016-03-03 19:42:25 UTC 
Created attachment 323018 [details] [review]
test

This test passes currently, but is a valuable addition to the opus-tests
Comment 1 Håvard Graff (hgr) 2016-04-05 11:00:41 UTC 
The test does *not* pass currently actually, it needs the patch I added as a dependency. Sorry.
Comment 2 Vincent Penquerc'h 2016-04-06 10:01:15 UTC 
Comment on attachment 323018 [details] [review]
test

looks ok.
Comment 3 Vincent Penquerc'h 2016-06-16 10:05:44 UTC 
Pushed, thanks:

commit 27e7ca3389ad7b63044fe3f2ae427fab0c7776c7
Author: Mikhail Fludkov <misha@pexip.com>
Date:   Thu Jun 16 10:55:52 2016 +0100

    opusdec: test for PLC timestamp when FEC is enabled.
Comment 4 Tim-Philipp Müller 2016-06-16 10:14:24 UTC 
Please git commit --amend commits to include the bug url before pushing :)
Comment 5 Vincent Penquerc'h 2016-06-16 10:22:46 UTC 
Oops. Again. Sorry...
Comment 6 Sebastian Dröge (slomo) 2016-06-17 08:30:10 UTC 
Or if you're lazy like me, use "git-bz" which can pull patches directly from Bugzilla and automatically adds the URL to the commit message :)