After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762868 - [review] cleanup handling GError by assuming valid error [danw/gerror-bgo762868]
[review] cleanup handling GError by assuming valid error [danw/gerror-bgo762868]
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-1-2
 
 
Reported: 2016-02-29 12:22 UTC by Thomas Haller
Modified: 2016-03-03 18:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[patch] original danw/wip/gerror branch (150.71 KB, patch)
2016-02-29 12:27 UTC, Thomas Haller 		none Details | Review

Description Thomas Haller 2016-02-29 12:22:36 UTC 
When a function indicates failure, it must also set the GError argument. No need to check for that.
Comment 1 Thomas Haller 2016-02-29 12:23:33 UTC 
Please review danw/gerror-bgo762868
Comment 2 Thomas Haller 2016-02-29 12:27:36 UTC 
Created attachment 322653 [details] [review]
[patch] original danw/wip/gerror branch

This branch is based on an old branch danw/wip/gerror by Dan.

It is obsolete, but attach it here for reference.

It applies on commit 73508704d888d0d83855348b0ca01a2f4d7b2207
Comment 3 Beniamino Galvani 2016-03-03 12:59:42 UTC 
danw/gerror-bgo762868 LGTM.
Comment 4 Beniamino Galvani 2016-03-03 13:31:19 UTC 
Found a crash, pushed fixup.
Comment 5 Dan Williams 2016-03-03 18:07:10 UTC 
LGTM, it even saves us memory :)