After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762812 - Refine the empty state of the overview
Refine the empty state of the overview
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Overview
3.19.x
Other Linux
: Normal minor
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-28 04:13 UTC by Michael Catanzaro
Modified: 2016-02-29 20:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
before (40.12 KB, image/png)
2016-02-28 04:17 UTC, Michael Catanzaro
  Details
after (20.53 KB, image/png)
2016-02-28 04:17 UTC, Michael Catanzaro
  Details
Improve the overview's empty state (8.62 KB, patch)
2016-02-28 04:20 UTC, Michael Catanzaro
none Details | Review
Improve the overview's empty state (8.64 KB, patch)
2016-02-29 01:48 UTC, Michael Catanzaro
committed Details | Review

Description Michael Catanzaro 2016-02-28 04:13:35 UTC
Make the overview's empty state look more GNOME-ey

(Planning to request freeze break for this.)
Comment 1 Michael Catanzaro 2016-02-28 04:17:07 UTC
Created attachment 322564 [details]
before
Comment 2 Michael Catanzaro 2016-02-28 04:17:18 UTC
Created attachment 322565 [details]
after
Comment 3 Michael Catanzaro 2016-02-28 04:20:20 UTC
Created attachment 322566 [details] [review]
Improve the overview's empty state

Not gonna admit how long it took me to figure out how to do this. This
"CSS" thing....
Comment 4 Carlos Garcia Campos 2016-02-28 08:11:10 UTC
I like it. There's one problem with this (and the previous patch) that I've just noticed. We need to use the same page, but with elements hidden, instead of using a different page. So that when something is loaded we just hide the initial page and show the overview. To see what I mean do the following:

 1.- Open a new ephy
 2.- Do not load anything in the initial page, open a new tab
 3.- Load something in the new tab
 4.- Visit the overview (initial) tab

It's kind of mixed. The web extension should remove the overview-empty class, or use display none, or whatever, it depends on how we do the html thing. I think it's easier to use the same html code and simply add remove classes to make it work as empty non empty.
Comment 5 Carlos Garcia Campos 2016-02-28 08:12:32 UTC
In any case, the bug is present before this patch, so it shouldn't block the new design, we can fix it while reworking this or just open a new bug and fix it in a follow up.
Comment 6 Michael Catanzaro 2016-02-28 17:47:35 UTC
(In reply to Carlos Garcia Campos from comment #5)
> In any case, the bug is present before this patch, so it shouldn't block the
> new design, we can fix it while reworking this or just open a new bug and
> fix it in a follow up.

Bug #762827
Comment 7 Matthias Clasen 2016-02-29 01:16:47 UTC
Review of attachment 322566 [details] [review]:

::: embed/ephy-about-handler.c
@@ +486,3 @@
+                            "  </div>\n"
+                            "</body></html>\n",
+                            icon_info ? gtk_icon_info_get_filename (icon_info) : "",

Here you check icon_info for NULL

@@ +489,3 @@
+                            /* Displayed when opening the browser for the first time. */
+                            _("Welcome to Web"), _("Start browsing and your most-visited sites will appear here."));
+    gtk_icon_info_free (icon_info);

...and here you don't
Comment 8 Michael Catanzaro 2016-02-29 01:45:25 UTC
Also: "gtk_icon_info_free has been deprecated since version 3.8 and should not be used in newly-written code. Use g_object_unref()"
Comment 9 Michael Catanzaro 2016-02-29 01:48:36 UTC
Created attachment 322618 [details] [review]
Improve the overview's empty state

Not gonna admit how long it took me to figure out how to do this. This
"CSS" thing....
Comment 10 Michael Catanzaro 2016-02-29 20:25:05 UTC
Attachment 322618 [details] pushed as 63fd0aa - Improve the overview's empty state