Created attachment 322564 [details]
before

Created attachment 322565 [details]
after

Created attachment 322566 [details] [review]
Improve the overview's empty state

Not gonna admit how long it took me to figure out how to do this. This
"CSS" thing....

I like it. There's one problem with this (and the previous patch) that I've just noticed. We need to use the same page, but with elements hidden, instead of using a different page. So that when something is loaded we just hide the initial page and show the overview. To see what I mean do the following:

 1.- Open a new ephy
 2.- Do not load anything in the initial page, open a new tab
 3.- Load something in the new tab
 4.- Visit the overview (initial) tab

It's kind of mixed. The web extension should remove the overview-empty class, or use display none, or whatever, it depends on how we do the html thing. I think it's easier to use the same html code and simply add remove classes to make it work as empty non empty.

In any case, the bug is present before this patch, so it shouldn't block the new design, we can fix it while reworking this or just open a new bug and fix it in a follow up.

(In reply to Carlos Garcia Campos from comment #5)
> In any case, the bug is present before this patch, so it shouldn't block the
> new design, we can fix it while reworking this or just open a new bug and
> fix it in a follow up.

Bug #762827

Review of attachment 322566 [details] [review]:

::: embed/ephy-about-handler.c
@@ +486,3 @@
+                            "  </div>\n"
+                            "</body></html>\n",
+                            icon_info ? gtk_icon_info_get_filename (icon_info) : "",

Here you check icon_info for NULL

@@ +489,3 @@
+                            /* Displayed when opening the browser for the first time. */
+                            _("Welcome to Web"), _("Start browsing and your most-visited sites will appear here."));
+    gtk_icon_info_free (icon_info);

...and here you don't

Also: "gtk_icon_info_free has been deprecated since version 3.8 and should not be used in newly-written code. Use g_object_unref()"

Created attachment 322618 [details] [review]
Improve the overview's empty state

Not gonna admit how long it took me to figure out how to do this. This
"CSS" thing....

Attachment 322618 [details] pushed as 63fd0aa - Improve the overview's empty state