After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762753 - test-ephy-snapshot-service is failing
test-ephy-snapshot-service is failing
Status: RESOLVED OBSOLETE
Product: epiphany
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks: 762752
 
 
Reported: 2016-02-26 20:57 UTC by Michael Catanzaro
Modified: 2018-08-03 20:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Some broken changes to snapshot-service-test (6.76 KB, patch)
2016-02-26 21:27 UTC, Michael Catanzaro 		none Details | Review
Some broken changes to snapshot-service-test (11.91 KB, patch)
2016-02-27 01:57 UTC, Michael Catanzaro 		none Details | Review

Description Michael Catanzaro 2016-02-26 20:57:48 UTC 
test-ephy-snapshot-service is failing since 18ad317 when I fixed it to not return success when there is an error.

I am not sure how this test ever worked (maybe it worked in WK1?) because it does not wait for pages to load before taking snapshots, the call to frameView->visibleContentRect() in webkitWebPageDidReceiveMessage (WebKitWebPage.cpp) returns an empty WebCore::IntRect, and in the end nullptr gets returned by webkit_web_view_get_snapshot_finish.
Comment 1 Michael Catanzaro 2016-02-26 21:19:20 UTC 
It still returns a nullptr snapshot even when spinning a nested main loop until the LOAD_COMPLETE event and waiting an extra five seconds. Maybe because the web_view is not actually visible?
Comment 2 Michael Catanzaro 2016-02-26 21:27:31 UTC 
Created attachment 322493 [details] [review]
Some broken changes to snapshot-service-test

Posting this just so it doesn't get lost.
Comment 3 Michael Catanzaro 2016-02-27 01:57:32 UTC 
Created attachment 322509 [details] [review]
Some broken changes to snapshot-service-test

Posting this just so it doesn't get lost.
Comment 4 GNOME Infrastructure Team 2018-08-03 20:46:55 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/epiphany/issues/303.