After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762738 - [PATCH] Fix -Werror build for clang
[PATCH] Fix -Werror build for clang
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
unspecified
Other FreeBSD
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2016-02-26 15:30 UTC by Ting-Wei Lan
Modified: 2016-03-07 15:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
event-manager: Don't use an enum as a null pointer constant (923 bytes, patch)
2016-02-26 15:31 UTC, Ting-Wei Lan 		none Details | Review
event-manager: Don't use an enum as a TpChannel pointer (935 bytes, patch)
2016-03-04 03:29 UTC, Ting-Wei Lan 		committed Details | Review

Description Ting-Wei Lan 2016-02-26 15:30:12 UTC 
The attached patch fixes one of the problem, which is caused by conversion from enum to pointer. Other warnings are caused by using deprecated functions webkit_dom_html_element_get_class_name, webkit_dom_html_element_set_class_name, soup_session_async_new, so they cannot be easily fixed.
Comment 1 Ting-Wei Lan 2016-02-26 15:31:31 UTC 
Created attachment 322471 [details] [review]
event-manager: Don't use an enum as a null pointer constant
Comment 2 Debarshi Ray 2016-03-03 19:11:53 UTC 
Review of attachment 322471 [details] [review]:

::: src/empathy-event-manager.c
@@ +799,3 @@
           /* We are invited to a room */
           DEBUG ("Have been invited to %s. Ask user if he wants to accept",
+              tp_channel_get_identifier (NULL));

This looks as wrong as the original code. Given that EmpathyTpChat is a TpTextChannel, it should be:
  tp_channel_get_identifier (TP_CHANNEL (tp_chat))
Comment 3 Ting-Wei Lan 2016-03-04 03:29:20 UTC 
Created attachment 323058 [details] [review]
event-manager: Don't use an enum as a TpChannel pointer
Comment 4 Debarshi Ray 2016-03-07 13:26:09 UTC 
Review of attachment 323058 [details] [review]:

Thanks for the new patch. It looks good to me.
Comment 5 Ting-Wei Lan 2016-03-07 15:13:28 UTC 
Attachment 323058 [details] pushed as 0bd09aa - event-manager: Don't use an enum as a TpChannel pointer