After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762609 - progress-info: check destination before referencing it
progress-info: check destination before referencing it
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-24 13:26 UTC by Razvan Chitu
Modified: 2016-02-24 16:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
progress-info: check destination before referencing it (1.39 KB, patch)
2016-02-24 13:26 UTC, Razvan Chitu 		committed Details | Review

Description Razvan Chitu 2016-02-24 13:26:38 UTC 
See attached patch.
Comment 1 Razvan Chitu 2016-02-24 13:26:42 UTC 
Created attachment 322238 [details] [review]
progress-info: check destination before referencing it

The progress info destination is obtainable through a getter function that
returns a reference to it. This reference is created without checking if the
destination is not null, which leads to critical warnings. In order to fix this,
check the destination before creating the reference.
Comment 2 Carlos Soriano 2016-02-24 13:55:24 UTC 
Review of attachment 322238 [details] [review]:

LGTM thanks Razvan!

Can you push to master, gnome-3-20 and gnome-3-18?
Comment 3 Razvan Chitu 2016-02-24 16:18:41 UTC 
Attachment 322238 [details] pushed as 9bc857c - progress-info: check destination before referencing it
Comment 4 Razvan Chitu 2016-02-24 16:19:30 UTC 
(In reply to Razvan Chitu from comment #3)
> Attachment 322238 [details] pushed as 9bc857c - progress-info: check
> destination before referencing it

Also pushed to gnome-3-20 and gnome-3-18