After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762248 - Don't use g_desktop_app_info_set_desktop_env
Don't use g_desktop_app_info_set_desktop_env
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-18 08:50 UTC by Carlos Soriano
Modified: 2016-03-01 10:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
main: remove g_desktop_app_info_set_desktop_env (872 bytes, patch)
2016-02-19 10:04 UTC, Razvan Chitu 		committed Details | Review

Description Carlos Soriano 2016-02-18 08:50:33 UTC 
is deprecated, find an alternative!
Comment 1 Razvan Chitu 2016-02-19 10:04:10 UTC 
Created attachment 321642 [details] [review]
main: remove g_desktop_app_info_set_desktop_env

The environment variable used in present is XDG_CURRENT_DESKTOP.
Comment 2 Razvan Chitu 2016-02-19 10:06:50 UTC 
(In reply to Razvan Chitu from comment #1)
> Created attachment 321642 [details] [review] [review]
> main: remove g_desktop_app_info_set_desktop_env
> 
> The environment variable used in present is XDG_CURRENT_DESKTOP.

I assumed that the value of XDG_CURRENT_DESKTOP should not be set within nautilus, because it would overwrite the information from the system. If it should be set, the patch can easily be modified.
Comment 3 Carlos Soriano 2016-02-26 07:43:45 UTC 
Cosimo, I'm not sure about this, can you take a look?
Comment 4 Carlos Soriano 2016-02-26 07:54:10 UTC 
To be clear, I'm mostly sure that this is correct. But I'm not sure if removing have some implications.
Comment 5 Cosimo Cecchi 2016-03-01 02:26:29 UTC 
Review of attachment 321642 [details] [review]:

Looks good to me, sorry for the late review.
Comment 6 Razvan Chitu 2016-03-01 10:50:35 UTC 
Comment on attachment 321642 [details] [review]
main: remove g_desktop_app_info_set_desktop_env

Attachment 321642 [details] pushed as 0e31141 - main: remove g_desktop_app_info_set_desktop_env