After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762184 - Autoconf check for C++11 comes after compile test for Gtk::Window::set_default_icon_name()
Autoconf check for C++11 comes after compile test for Gtk::Window::set_defaul...
Status: RESOLVED FIXED
Product: gparted
Classification: Other
Component: application
GIT HEAD
Other Linux
: Normal normal
: ---
Assigned To: Mike Fleetwood
gparted maintainers alias
Depends on:
Blocks:
 
 
Reported: 2016-02-17 13:36 UTC by Mike Fleetwood
Modified: 2016-04-26 15:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix autoconf check for set_default_icon_name() (3.76 KB, patch)
2016-02-17 17:33 UTC, Mike Fleetwood 		none Details | Review

Description Mike Fleetwood 2016-02-17 13:36:52 UTC 
Yaakov Selkowitz in bug 756035 comment #4 wrote:
> The added C++11 configure tests are too late to help the
> Gtk::Window::set_default_icon_name compile-and-link test, which therefore
> reports a false negative in Fedora 23.  (Fedora 24 is using GCC 6, which
> defaults to gnu++14, which "fixes" the test.)  If that test really can't be
> made into a simple PKG_CHECK_EXISTS check, then the tests need to be
> reordered accordingly.
Comment 1 Mike Fleetwood 2016-02-17 17:33:54 UTC 
Created attachment 321524 [details] [review]
Fix autoconf check for set_default_icon_name()

Hi Curtis,

Here's the patch for this.  After looking at the gtkmm source found that
set_default_icon_name() wasn't actually introduced until gtkmm 2.11.1.
Therefore switched to a PKG_CHECK_EXISTS check.

successfully compiled on:
CentOS 5            gtkmm 2.10
CentOS 6            gtkmm 2.18
Ubuntu 12.04 LTS    gtkmm 2.24
Fedora 23           gtkmm 2.24.4
Fedora Rawhide (24) gtkmm 2.24.4

Thanks,
Mike
Comment 2 Curtis Gedak 2016-02-18 17:22:17 UTC 
Hi Mike,

In the patch in comment #1, one of the lines says:

   Check for gtkmm >= 2.11.1 to determine availability of
   Gtk::MessageDialog::get_message_area().

Because it replaced a line that said:

   Check for Gtk::Window::set_default_icon_name() method

did you wish it to say:

   Check for gtkmm >= 2.11.1 to determine availability of
   Gtk::Window::set_default_icon_name()

instead?

I will test the patch on some other distros.

Curtis
Comment 3 Mike Fleetwood 2016-02-18 21:06:25 UTC 
Hi Curtis,

Yes I did intend it to say:

   Check for gtkmm >= 2.11.1 to determine availability of
   Gtk::Window::set_default_icon_name()

Cut and paste error.  Appreciate it if you could fix when you commit the
patch.

Thanks,
Mike
Comment 4 Curtis Gedak 2016-02-18 21:19:05 UTC 
Thank you Mike for this improvement for autoconf configuration.

Using the patch from comment #1 I successfully tested the following
commands:

  ./configure && make
  make distcheck

on the following distros:

  Debian    7
  Debian    8
  kubuntu  12.04 LTS
   ubuntu  15.10
  openSUSE 13.2

All looks good to me.

As such the patch from comment #1 (with aforementioned text change)
has been committed to the git repository for inclusion in the next
release of GParted.

The relevant git commit can be viewed at the following link:

Change to autoconf PKG_CHECK_EXISTS for set_default_icon_name() method (#762184)
https://git.gnome.org/browse/gparted/commit/?id=ff9aeb809277b03c2d46fb16985933cf4adae061
Comment 5 Curtis Gedak 2016-04-26 15:55:58 UTC 
This enhancement was included in the GParted 0.26.0 release on April 26, 2016.