GNOME Bugzilla – Bug 762144
dashdemux: tests: add new dashdemux tests
Last modified: 2016-04-22 21:20:03 UTC
refactor the current adaptive demux unit test support and extend it with new tests.
Created attachment 321379 [details] [review] 1/11 added support to pass various parameters to http src callbacks requires https://bugzilla.gnome.org/show_bug.cgi?id=762142 to be merged first
Created attachment 321380 [details] [review] 2/11 create a GstDashDemuxTestCase class
Created attachment 321381 [details] [review] 3/11 moved testQuery after testFragmentDownloadError
Created attachment 321382 [details] [review] 4/11 tested latency query
Created attachment 321383 [details] [review] 5/11 refactor testFragmentDownloadError
Created attachment 321384 [details] [review] 6/11 added test for download errors during header download
Created attachment 321385 [details] [review] 7/11 added test for media download error for in stream fragment
Created attachment 321386 [details] [review] 8/11 ignore leading and trailing spaces in content protection's scheme ID URI this was reported in https://bugzilla.gnome.org/show_bug.cgi?id=758064 but re-added here because the associated test was changed.
Created attachment 321387 [details] [review] 9/11 added content protection test this was reported in https://bugzilla.gnome.org/show_bug.cgi?id=758064 but re-added here because it now depends on some test framework changes done here.
Created attachment 321388 [details] [review] 10/11 improved checks for expected data
Created attachment 321389 [details] [review] 11/11 use macro to define names of request and response structs
References to the content protection fix were added on the proper bug, the others are listed here. commit 00a74e98b3ed0dfd3b621049a8bdca70cc025ca2 Author: Florin Apostol <florin.apostol@oregan.net> Date: Tue Feb 16 14:26:55 2016 +0000 adaptivedemux: tests: use macro to define names of request and response structs Following the Don't Repeat Yourself principle, define macros for the structures that contain the request and response headers, so that the name is not repeated in multiple places in multiple files. https://bugzilla.gnome.org/show_bug.cgi?id=762144 commit 3224cfd0b5569d5edd2fd617210fa91b4d201fee Author: Florin Apostol <florin.apostol@oregan.net> Date: Tue Feb 16 14:26:42 2016 +0000 adaptivedemux: tests: improved checks for expected data Check the size of received data for each buffer received by AppSink https://bugzilla.gnome.org/show_bug.cgi?id=762144 commit 5b6b24859f969654829fbf860b9677975610bddb Author: Florin Apostol <florin.apostol@oregan.net> Date: Tue Feb 16 14:26:05 2016 +0000 dashdemux: tests: added test for media download error for in stream fragment Tested download error for a fragment that is not the last media fragment in the stream. https://bugzilla.gnome.org/show_bug.cgi?id=762144 commit 01397f56f2da0a7e2d2e704597505a66c8e837a5 Author: Florin Apostol <florin.apostol@oregan.net> Date: Tue Feb 16 14:25:45 2016 +0000 dashdemux: tests: added test for download errors during header download Test header download error. Let the adaptive demux download a few bytes, then instruct the GstTestHTTPSrc element to generate an error while the fragment header is still being downloaded. https://bugzilla.gnome.org/show_bug.cgi?id=762144 commit b8ba8a3b7e028f5083d8926e2267f85aadd799ae Author: Florin Apostol <florin.apostol@oregan.net> Date: Tue Feb 16 14:25:32 2016 +0000 dashdemux: tests: refactor testFragmentDownloadError Renamed testFragmentDownloadError to testMediaDownloadErrorLastFragment. Added gst_adaptive_demux_test_unexpected_eos function. Remove unneeded testFragmentDownloadErrorCheckSizeOfDataReceived. https://bugzilla.gnome.org/show_bug.cgi?id=762144 commit f89fe6cb45578a21bdf54107bf5e92ccb4b97be7 Author: Florin Apostol <florin.apostol@oregan.net> Date: Tue Feb 16 14:25:04 2016 +0000 dashdemux: tests: tested latency query Updated query test to also check if dash responds correctly to a latency query. https://bugzilla.gnome.org/show_bug.cgi?id=762144 commit a7f1eb234f390a1f03a50e410c5d5cf39b4af5ed Author: Florin Apostol <florin.apostol@oregan.net> Date: Tue Feb 16 14:24:49 2016 +0000 dashdemux: tests: moved testQuery after testFragmentDownloadError Moved testQuery after testFragmentDownloadError so that testDownloadError and testFragmentDownloadError are grouped together. The commit just moved the testQueryCheckDataReceived and GST_START_TEST (testQuery) functions but git gets confused in matching the lines and reports a lot of changes in the patch. https://bugzilla.gnome.org/show_bug.cgi?id=762144 commit f27d585078ca0aef8a251ea15b5d82da6875796a Author: Florin Apostol <florin.apostol@oregan.net> Date: Tue Feb 16 14:24:26 2016 +0000 adaptivedemux: tests: create a GstDashDemuxTestCase class Create a GstDashDemuxTestCase class that extends from GstAdaptiveDemuxTestCase. This new class will contain all the DASH specific fields. https://bugzilla.gnome.org/show_bug.cgi?id=762144 commit 9c0489e73efa335f2b32d1ed24fa6ed1bd1c4fd8 Author: Florin Apostol <florin.apostol@oregan.net> Date: Tue Feb 16 14:24:09 2016 +0000 dashdemux: tests: added support to pass various parameters to http src callbacks Added support to pass various parameters to http src callbacks using GstStructure. https://bugzilla.gnome.org/show_bug.cgi?id=762144
Comment on attachment 321386 [details] [review] 8/11 ignore leading and trailing spaces in content protection's scheme ID URI Actually is for another bug: #758064
Comment on attachment 321387 [details] [review] 9/11 added content protection test This is for bug #758064