After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762055 - gstreamer-vaapi build errors fix
gstreamer-vaapi build errors fix
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-15 01:00 UTC by Vineeth
Modified: 2016-02-15 17:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
vaapibufferproxy build error (1.32 KB, patch)
2016-02-15 01:01 UTC, Vineeth
none Details | Review
vaapibufferproxy build error (1.32 KB, patch)
2016-02-15 01:04 UTC, Vineeth
none Details | Review
tests:simple encoder: build error (889 bytes, patch)
2016-02-15 01:05 UTC, Vineeth
none Details | Review
tests: simple-encoder: fix build error (886 bytes, patch)
2016-02-15 17:23 UTC, Víctor Manuel Jáquez Leal
committed Details | Review
libs: fix build error (2.43 KB, patch)
2016-02-15 17:23 UTC, Víctor Manuel Jáquez Leal
committed Details | Review

Description Vineeth 2016-02-15 01:00:50 UTC
There are build errors while compiling gstreamer-vaapi.
Fix the same
Comment 1 Vineeth 2016-02-15 01:01:43 UTC
Created attachment 321170 [details] [review]
vaapibufferproxy build error

gst_vaapi_buffer_proxy_acquire_handle is used only when version check is (0,36,0).
Hence definition should also be moved inside version check (0,36,0)
Comment 2 Vineeth 2016-02-15 01:04:05 UTC
Created attachment 321171 [details] [review]
vaapibufferproxy build error

gst_vaapi_buffer_proxy_acquire_handle is used only when version check is (0,36,0).
Hence definition should also be moved inside version check (0,36,0)
Comment 3 Vineeth 2016-02-15 01:05:04 UTC
Created attachment 321172 [details] [review]
tests:simple encoder: build error
Comment 4 Víctor Manuel Jáquez Leal 2016-02-15 17:01:36 UTC
I have just compiled master against libva 1.3.0 (API v0.35) and found that more functions warns about being unused: 

gst_vaapi_buffer_proxy_acquire_handle
gst_vaapi_buffer_proxy_release_handle
gst_vaapi_buffer_proxy_finalize
gst_vaapi_buffer_proxy_class
Comment 5 Víctor Manuel Jáquez Leal 2016-02-15 17:23:02 UTC
Created attachment 321275 [details] [review]
tests: simple-encoder: fix build error

argument mismatch of gsize with 'long unsigned int'
Comment 6 Víctor Manuel Jáquez Leal 2016-02-15 17:23:08 UTC
Created attachment 321276 [details] [review]
libs: fix build error

gst_vaapi_buffer_proxy_{acquire_handle,release_handle,finalize,class}
functions are used only when libva's API version is greater than 0.36.0

This patch guards those functions completely rather than just their
content. The patch is a continuation of commit 38f8fea4

Original-patch-by: Vineeth TM <vineeth.tm@samsung.com>
Comment 7 Víctor Manuel Jáquez Leal 2016-02-15 17:29:58 UTC
Attachment 321275 [details] pushed as ba701d5 - tests: simple-encoder: fix build error
Attachment 321276 [details] pushed as 60ebfbc - libs: fix build error