After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761985 - os.name can be wrong in some context
os.name can be wrong in some context
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks: 658126
 
 
Reported: 2016-02-13 08:54 UTC by Nicola Fontana
Modified: 2018-01-25 22:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed solution (1.09 KB, patch)
2016-02-13 09:09 UTC, Nicola Fontana 		none Details | Review
Proposed solution: the previous one was a wrong patch (2.79 KB, patch)
2016-02-13 09:12 UTC, Nicola Fontana 		committed Details | Review

Description Nicola Fontana 2016-02-13 08:54:09 UTC 
When g-ir-scanner is called during a cross-compilation of gobject-introspection, os.name always refers to the build OS but in some context (e.g. when resolving libraries) we really want to use the host OS.
Comment 1 Nicola Fontana 2016-02-13 09:09:52 UTC 
Created attachment 321056 [details] [review]
Proposed solution
Comment 2 Nicola Fontana 2016-02-13 09:12:32 UTC 
Created attachment 321058 [details] [review]
Proposed solution: the previous one was a wrong patch
Comment 3 Colin Walters 2016-02-13 12:19:12 UTC 
Review of attachment 321058 [details] [review]:

Hmm.  This seems reasonable, I'm just wondering if there's a way we can automatically inherit from Autoconf/cmake's config?  Nevertheless, OK to commit as is.

(We'll need to document these things somewhere, but don't block on that either)
Comment 4 Colin Walters 2016-02-13 12:19:12 UTC 
Review of attachment 321058 [details] [review]:

Hmm.  This seems reasonable, I'm just wondering if there's a way we can automatically inherit from Autoconf/cmake's config?  Nevertheless, OK to commit as is.

(We'll need to document these things somewhere, but don't block on that either)
Comment 5 Emmanuele Bassi (:ebassi) 2018-01-25 22:15:58 UTC 
Pushed attachment 321058 [details] [review] after rebasing it against current master.

I've also pushed a commit that adds GI_HOST_OS to the g-ir-scanner man page.