GNOME Bugzilla – Bug 761971
Bring the tutorial up to date with clutter 1.24
Last modified: 2019-02-23 02:46:16 UTC
Created attachment 321024 [details] [review] updates configure.ac to use c++11; subdir-objects no longer works. A number of updates: All of the examples failed to compile due to using deprecated API The tutorial documentation is based on the previous model of Clutter; it now has the Actor as the central container and object. Numerous updates required to reflect this.
Created attachment 321025 [details] [review] Updates Makefile.am With the configure.ac patch, build proceeds. These two patches do create the examples in the parent directory. I was unable to get subdir-objects to create the children in their own directory (this is a non-recursive Makefile); while this is a regression, I couldn't solve it quickly, and a suboptimal outcome that builds beats FTB code IMHO. This also comments out all the examples; every one of them uses deprecated API and needs updating. I've chosen to do this as a series of patches that update each one in turn, with the manual updated alongside.
Created attachment 321026 [details] [review] Updates stage example
Created attachment 321027 [details] [review] Removes a m4 file that is no longer used this removes a dk_warn.m4 file; I believe its been superseded by MM_WARNINGS.
Created attachment 321028 [details] [review] Updates the stage widget(embed) example
Created attachment 321029 [details] [review] Updates the manual.
Created attachment 321030 [details] [review] Actor example now works
Created attachment 321031 [details] [review] Repair of the actor transformations example from the manual.
Created attachment 321032 [details] [review] Adds another transformation example This is rather larger than most examples; I've added it in not only for the coding, but because I find it useful to be able to see how the different transformations interact with each other.
Created attachment 321033 [details] [review] Manual update
Review of attachment 321027 [details] [review]: This should be squashed together with the commit that changes the macro that is used in configure.ac.
Comment on attachment 321027 [details] [review] Removes a m4 file that is no longer used I have committed the change of macro use as one small commit.
Review of attachment 321024 [details] [review]: I have the change of warning macro, and the use of C++11, as separate commits.
Review of attachment 321025 [details] [review]: I guess this might be meant to be in the same commit as the configure.ac change. But please keep the general build changes separate from the addition of source files. And please don't change the variable names unnecessarily.
Comment on attachment 321026 [details] [review] Updates stage example Pushed, with a slightly improved commit message.
Review of attachment 321028 [details] [review]: Can we just have the fix for the example without the intermediate removal of the example from the build?
Comment on attachment 321031 [details] [review] Repair of the actor transformations example from the manual. I have pushed this without the Makefile.am changes. The change to the set_size() call should really have some explanation in the commit message.
(In reply to Murray Cumming from comment #15) > Can we just have the fix for the example without the intermediate removal of > the example from the build? And the commit message should say why the change was made, please.
Review of attachment 321029 [details] [review]: This seems to contain many whitespace changes. Please separate these so the actual content changes are in a separate commit. And the commit message should describe the changes, at least briefly.
Review of attachment 321032 [details] [review]: I think you forgot to "git add" the actual new source file.
(In reply to Murray Cumming from comment #13) > Review of attachment 321025 [details] [review] [review]: > > I guess this might be meant to be in the same commit as the configure.ac > change. But please keep the general build changes separate from the addition > of source files. And please don't change the variable names unnecessarily. I added nobase because as it stands the Makefile was placing the output in the projects base directory, and I wanted them to remain in the directory their input files were contained in.
If this is still an issue it should probably be transferred to https://gitlab.gnome.org/GNOME/cluttermm as we're going to shutdown GNOME Bugzilla.
Closing per last comment.