GNOME Bugzilla – Bug 761884
Fix layers popover design nits
Last modified: 2016-02-11 23:21:48 UTC
See patches! Before: http://imgur.com/Wcq1iZ0 After: http://imgur.com/mO9zkss
Created attachment 320917 [details] [review] Layers: remove margin before visibleButton This margin was here when the label was first so the text wasn't right up-against the edge. Now that the button is the first thing in the ListBoxRow, the margin looks weird.
Created attachment 320918 [details] [review] Layers: deactivate ListBoxRow if layer is hidden This way you can't click on the row and center a shape layer that isn't visible!
Created attachment 320919 [details] [review] Fixup indentation
Created attachment 320920 [details] [review] Layers: deactivate ListBoxRow if layer is hidden This way you can't click on the row and center a shape layer that isn't visible!
Just from the screenshot. I prefer the way it is in the "Before" image, in the "After" image you have more margin in the left side than in the bottom and the top of the eye image (unless you've confused the URLs when posting the ticket!).
Oops! The images are swapped. The "After" should have less margin on the right and the bottom row should not be darkened (dark = activatable).
Attachment 320917 [details] pushed as 0104e6f - Layers: remove margin before visibleButton Attachment 320919 [details] pushed as 283f864 - Fixup indentation Attachment 320920 [details] pushed as e8daecd - Layers: deactivate ListBoxRow if layer is hidden