GNOME Bugzilla – Bug 761849
Update details dialog stays open when browsing to a software's page from shell
Last modified: 2018-01-24 17:01:13 UTC
Created attachment 320852 [details] Screenshots showing the problem When checking an update's details, if you try to open a software's page from the shell, the page is properly opened but the update details dialog stays in front of it. I would expect software to just show the software's page and not being in a sort of mixed state.
Easily reproducible if the updates review dialog is open which happens after the updates have been installed or if it is forced with this command: gnome-software --mode=updated and then when a user tries to open gnome-software in any other mode without closing the updates review dialog first. The question is: what should we do in such case? * force close the dialog - this is probably the best option although it has a disadvantage: the updates review dialog will disappear and the user will lose the opportunity to review the updates, we should assume forever because not everybody knows the "--mode=updated" trick; * display the message: "You should review the updates and close the dialog before doing anything else"; * ignore all mode changes until the user closes the updates dialog (but the users will be confused why their actions do nothing); * store all requests to display anything in gnome-software and execute those requests only after the user closes the dialog (but again the users will be confused why their actions do nothing and then even more confused why something happens after the dialog is closed; especially if they did multiple action requests because the first request did nothing). Probably the same would happen when any other dialog box is open. See also: similar bug 759038.
I think the only sane thing to do here is to close the modal. I've tried to write a patch to fix this bug hit a shell bug; I'm trying to fix it now.
Seems to be easy to fix: whenever you switch the page: * check the list of all app windows; * if a topmost window is a dialog then close it; * otherwise end; * repeat; The only way to switch the page while a modal is open is to launch another gnome-software --mode=xxxx command.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-software/issues/41.