After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761810 - gio: Support using GDBusObjectManagerServer at path ‘/’
gio: Support using GDBusObjectManagerServer at path ‘/’
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gdbus
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2016-02-10 09:41 UTC by Philip Withnall
Modified: 2016-06-15 17:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gio: Support using GDBusObjectManagerServer at path ‘/’ (6.92 KB, patch)
2016-02-10 09:41 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2016-02-10 09:41:09 UTC 
Simple patch attached.
Comment 1 Philip Withnall 2016-02-10 09:41:12 UTC 
Created attachment 320775 [details] [review]
gio: Support using GDBusObjectManagerServer at path ‘/’

Previously this would cause an assertion failure when checking the paths
of exported objects, as it would try to check that their paths started
with ‘//’ due to mishandling the root object case.

Includes a unit test.
Comment 2 Allison Karlitskaya (desrt) 2016-06-15 16:33:58 UTC 
Review of attachment 320775 [details] [review]:

Go ahead after the fixup.  Or don't do the fixup.  I don't really mind, either way =)

::: gio/gdbusobjectmanagerserver.c
@@ +178,3 @@
       g_assert (g_variant_is_object_path (g_value_get_string (value)));
       manager->priv->object_path = g_value_dup_string (value);
+      if (g_strcmp0 (manager->priv->object_path, "/") == 0)

g_str_equal() plz
Comment 3 Philip Withnall 2016-06-15 17:28:02 UTC 
Attachment 320775 [details] pushed as b26b083 - gio: Support using GDBusObjectManagerServer at path ‘/’