Created attachment 320675 [details] [review]
web-view: Add accessor to get current error page

Created attachment 320676 [details] [review]
session: pages loading during normal shutdown did not crash

Currently we consider any page loading when Epiphany quits to have
crashed. Instead, we should only consider it crashed if Epiphany did not
shut down cleanly, or if it was really a crash error page.

What do you think, Carlos?

Comment on attachment 320675 [details] [review]
web-view: Add accessor to get current error page

Maybe it would be easier to just expose ephy_web_view_is_crashed_error() or something simialr for consistency with is_blank, is_overview. Or even is_error_page that returns the error page. But either way is fine with me anyway.

Review of attachment 320676 [details] [review]:

Ok.

(In reply to Carlos Garcia Campos from comment #4)
> Comment on attachment 320675 [details] [review] [review]
> web-view: Add accessor to get current error page
> 
> Maybe it would be easier to just expose ephy_web_view_is_crashed_error() or
> something simialr for consistency with is_blank, is_overview. Or even
> is_error_page that returns the error page. But either way is fine with me
> anyway.

Good point... but there's already _load_error_page(), which takes the enum, so I think exposing it here is maybe best. Doesn't really matter.

Attachment 320675 [details] pushed as bc3579e - web-view: Add accessor to get current error page
Attachment 320676 [details] pushed as 21a50e2 - session: pages loading during normal shutdown did not crash

I don't like "_is_error_page that returns the error page," though, even if the result can be used as a bool, I'd rather "is" functions return only bools.