After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761723 - Polari doesn't recognize mentions with unmatching letter case
Polari doesn't recognize mentions with unmatching letter case
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
3.18.x
Other other
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-08 17:38 UTC by tirifto
Modified: 2016-02-18 00:17 UTC
See Also:
GNOME target: ---
GNOME version: 3.17/3.18

Attachments
util: Casefold basenick (936 bytes, patch)
2016-02-08 19:42 UTC, Florian Müllner 		committed Details | Review
room: Use case-insensitive matching for nick highlights (2.66 KB, patch)
2016-02-08 19:42 UTC, Florian Müllner 		committed Details | Review
Recognize mentions with unmatching letter case (1.40 KB, patch)
2016-02-10 18:36 UTC, Bishakh Ghosh 		none Details | Review

Description tirifto 2016-02-08 17:38:55 UTC 
When someone mentions my name (Tirifto) and uses letters of different case (tirifto) (TiRifTo), Polari doesn't recognize the mention. There is no highlight and no notification.

Ideally, Polari should recognize a mention regardless of the case.
Comment 1 Florian Müllner 2016-02-08 19:42:38 UTC 
Created attachment 320647 [details] [review]
util: Casefold basenick

The purpose of "basenicks" is to group different nicks that supposedly
identify the same person - it makes sense to not only apply this to
different suffixes, but also differences in case.
Comment 2 Florian Müllner 2016-02-08 19:42:48 UTC 
Created attachment 320648 [details] [review]
room: Use case-insensitive matching for nick highlights

For nicks that aren't all lowercase(*), it is easy enough to get the
case wrong when not using tab completion, so use case-insensitive
matching for nick highlights.

(*) or shouty all uppercase of course
Comment 3 Bishakh Ghosh 2016-02-10 18:36:10 UTC 
Created attachment 320822 [details] [review]
Recognize mentions with unmatching letter case

Convert the message text to lowercase and search for nick.
Comment 4 Florian Müllner 2016-02-18 00:17:31 UTC 
Attachment 320647 [details] pushed as 7d6a7db - util: Casefold basenick
Attachment 320648 [details] pushed as 7ba3a92 - room: Use case-insensitive matching for nick highlights