After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761706 - Missing mnemonics in new strings
Missing mnemonics in new strings
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
3.19.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-08 12:01 UTC by Piotr Drąg
Modified: 2016-02-08 14:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Preferences: add mnemonics (4.71 KB, patch)
2016-02-08 14:26 UTC, Carlos Soriano 		committed Details | Review

Description Piotr Drąg 2016-02-08 12:01:06 UTC 
Some strings added lately don't have mnemonics, which makes it harder to navigate using keyboard. It's also an a11y issue.

These are "Search subfolders on local file systems", "Search subfolders on remote file systems", "Show context menu item to delete files permanently" and "Show context menu item to create links from copied files" in the preferences dialog, as well as most strings in the new search popover. There might be more that I didn't catch.
Comment 1 Carlos Soriano 2016-02-08 12:17:36 UTC 
I'm not sure what to do with the search popover, I cannot provide a mnemonic for every type that is available, and therefore I cannot provide a mnemonic for the "What" part where you select a file type.

Do you have any insights for it?
Comment 2 Piotr Drąg 2016-02-08 12:45:50 UTC 
I don't know what to do with this part, unfortunately.
Comment 3 Carlos Soriano 2016-02-08 13:30:34 UTC 
(In reply to Piotr Drąg from comment #2)
> I don't know what to do with this part, unfortunately.

Let's fix the other parts for now then.
Comment 4 Carlos Soriano 2016-02-08 14:26:42 UTC 
Created attachment 320632 [details] [review]
Preferences: add mnemonics

They were missing.
Comment 5 Carlos Soriano 2016-02-08 14:28:15 UTC 
Hope now it's fine (everything except the search popover).
Feel free to reopen if no.

Attachment 320632 [details] pushed as 696ea24 - Preferences: add mnemonics
Comment 6 Carlos Soriano 2016-02-08 14:29:21 UTC 
To gnome-3-20 as well.
Comment 7 Piotr Drąg 2016-02-08 14:30:22 UTC 
Thank you!