After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761647 - yelp-document: Fix return type of document_indexed
yelp-document: Fix return type of document_indexed
Status: RESOLVED FIXED
Product: yelp
Classification: Applications
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Yelp maintainers
Yelp maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-06 20:46 UTC by Michael Catanzaro
Modified: 2016-02-06 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
yelp-document: Fix return type of document_indexed (2.02 KB, patch)
2016-02-06 20:46 UTC, Michael Catanzaro 		committed Details | Review

Description Michael Catanzaro 2016-02-06 20:46:09 UTC 
It's a GSourceFunc, so it'd better return a gboolean. This doesn't seem
to be causing any problems in Fedora, but in Endless it's causing 100%
CPU usage after executing a search, because the source never gets
removed.
Comment 1 Michael Catanzaro 2016-02-06 20:46:11 UTC 
Created attachment 320557 [details] [review]
yelp-document: Fix return type of document_indexed
Comment 2 David King 2016-02-06 20:57:46 UTC 
Review of attachment 320557 [details] [review]:

Seems fine to me.
Comment 3 David King 2016-02-06 21:07:00 UTC 
Probably a duplicate of bug 661509, which I was never able to reproduce.
Comment 4 Michael Catanzaro 2016-02-06 21:47:09 UTC 
I think it's actually not a duplicate, but a very very convincing red herring. In that bug Matthias notes "libyelp/yelp-document.c:request_try_free looks fishy", well I found that too debugging this in Yelp 3.17.2, but that bug turned out to be fixed somehow during the WK2 port, and in case the 100% CPU usage doesn't start until navigating to a new page. This bug, in contrast, occurs immediately after starting a search, occurs still in git master, and is characterized by unending invocations of document_indexed rather than request_try_free.
Comment 5 Michael Catanzaro 2016-02-06 21:47:33 UTC 
Attachment 320557 [details] pushed as 28a8208 - yelp-document: Fix return type of document_indexed