After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761552 - Warnings in filechooser when typing-to-search in Recent
Warnings in filechooser when typing-to-search in Recent
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
Federico Mena Quintero
Depends on:
Blocks:
 
 
Reported: 2016-02-04 13:19 UTC by LRN
Modified: 2016-02-04 15:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't do remote checks on NULL files (1.88 KB, patch)
2016-02-04 13:19 UTC, LRN 		committed Details | Review

Description LRN 2016-02-04 13:19:43 UTC 
How to reproduce:
* Create a filechooser with a filter that doesn't match anything
* Run filechooser. "Recent" place will be selected by default (it is for me)
* Start typing to search
GTK will spew a few warnings.
This happens because nothing is found and location of the GtkQuery
remains NULL, which is then passed to some functions for checking.
Comment 1 LRN 2016-02-04 13:19:49 UTC 
Created attachment 320430 [details] [review]
Don't do remote checks on NULL files

Calling _gtk_file_consider_as_remote() with a NULL argument
results in warnings being thrown.

Note that query->priv->location being NULL is a state that does
not seem to be invalid by itself.

This could happen if you do search-as-you-type in a filechooser,
which has a filter that does not match anything *and* the current
"place" selected is "Recent".
Comment 2 Matthias Clasen 2016-02-04 15:24:14 UTC 
Review of attachment 320430 [details] [review]:

ok
Comment 3 LRN 2016-02-04 15:59:47 UTC 
Attachment 320430 [details] pushed as 4a49d8d - Don't do remote checks on NULL files