After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761546 - Undoing deletion with Ctrl+Z does not affect visibility of undo notification
Undoing deletion with Ctrl+Z does not affect visibility of undo notification
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: File and Folder Operations
3.18.x
Other Linux
: Normal minor
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-04 11:52 UTC by Bastian Ilsø
Modified: 2016-03-07 10:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
window: hide delete notification on undo (1.08 KB, patch)
2016-03-05 11:09 UTC, Razvan Chitu 		committed Details | Review

Description Bastian Ilsø 2016-02-04 11:52:33 UTC 
If I delete a file and use Ctrl+Z to undo deleting it, the undo notification is still open. I think it would make sense to close it (unless the undo notification refers the notification refers to undoing that I undid deleting it, but that sounds a bit hairy).
Comment 1 Razvan Chitu 2016-03-05 11:09:00 UTC 
Created attachment 323144 [details] [review]
window: hide delete notification on undo

In Nautilus, after a delete operation, an undo notification is shown to the user.
If the operation is undone by other means (such as the Ctrl+Z shortcut), the
notification is not automatically hidden, which can lead to an invalid undo
operation. In order to fix this, hide the notification on an undo operation.

Hide notification in the "undo-changed" signal handler.
Comment 2 Carlos Soriano 2016-03-06 21:36:12 UTC 
Review of attachment 323144 [details] [review]:

LGTM thanks!
Comment 3 Razvan Chitu 2016-03-07 08:27:43 UTC 
Comment on attachment 323144 [details] [review]
window: hide delete notification on undo

Attachment 323144 [details] pushed as d304c8a - window: hide delete notification on undo
Comment 4 Carlos Soriano 2016-03-07 10:24:43 UTC 
can you push to gnome-3-20 as well?
Comment 5 Razvan Chitu 2016-03-07 10:54:06 UTC 
(In reply to Carlos Soriano from comment #4)
> can you push to gnome-3-20 as well?

attachment 323144 [details] [review] pushed as 7e843a9