Created attachment 320443 [details] [review]
Place Icons in favorite-popover are always lost

Favorite-popover always display default Icons as icons are not present
in maps-places.json. Now we save place icon names.

Created attachment 320457 [details] [review]
Place Icons in favorite-popover are always lost

Favorite-popover always display default Icons as icons are not present
in maps-places.json. Now we save place icon names.

Review of attachment 320457 [details] [review]:

Looks good otherwise, I think!

::: src/placeListRow.js
@@ +66,3 @@
+        } else {
+            this._icon.gicon = this.place.icon;
+        }

Minor nitpick, I think the braces can be skipped here, especially since both parts are single statements.

Created attachment 320478 [details] [review]
Place Icons in favorite-popover are always lost

Favorite-popover always display default icons as icons are not present
in maps-places.json. Now we save place icon names.

Created attachment 320479 [details] [review]
Place: Fix storing of place_type

Place: Fix storing of place_type

The icon for a place is constructed in geocode-glib from
the place place_type. It seems we forget to store it in our
place store.

https://bugzilla.gnome.org/show_bug.cgi?id=761533

Alaf: Does the patch above solve the issue for you?

Review of attachment 320478 [details] [review]:

Thanks!

The icon should be constructed from the place place_type and should be done for us in geocode-glib. The bug is why this is not happening I think.

Created attachment 320480 [details] [review]
Icons of favorite places are always lost

As Icons are not saved in maps.places-json, favorite places always display
dafault icons. Now we save place icon names

Jonas : Yes :)

Comment on attachment 320479 [details] [review]
Place: Fix storing of place_type

Attachment 320479 [details] pushed as e2e3e9c - Place: Fix storing of place_type