After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761484 - Spinbuttons in headerbars are way too tall
Spinbuttons in headerbars are way too tall
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
3.19.x
Other Windows
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-02-03 06:36 UTC by LRN
Modified: 2016-02-03 17:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Testcase (1.24 KB, text/x-csrc)
2016-02-03 06:36 UTC, LRN 		Details
spinbutton not in headerbar even taller (4.71 KB, image/png)
2016-02-03 07:25 UTC, Matthias Clasen 		Details
Testcase v2 (1.35 KB, text/plain)
2016-02-03 09:08 UTC, LRN 		Details
spinbutton not in headerbar not taller when not filling (2.56 KB, image/png)
2016-02-03 09:09 UTC, LRN 		Details

Description LRN 2016-02-03 06:36:16 UTC 
Created attachment 320317 [details]
Testcase

A spinbutton that is placed in a headerbar becomes way too tall, compared to spinbuttons not placed in a headerbar.
Comment 1 Matthias Clasen 2016-02-03 07:25:12 UTC 
Created attachment 320319 [details]
spinbutton not in headerbar even taller
Comment 2 LRN 2016-02-03 09:08:00 UTC 
Created attachment 320322 [details]
Testcase v2

With added valign=GTK_ALIGN_CENTER and expand=FALSE for win_spin.
Comment 3 LRN 2016-02-03 09:09:42 UTC 
Created attachment 320323 [details]
spinbutton not in headerbar not taller when not filling

This is taken from testcase v2
Comment 4 Matthias Clasen 2016-02-03 15:35:58 UTC 
Some debugging revealed that this is caused by min-height and margin coming from the theme for buttons in headerbars. The spinbutton has button nodes which are affected by this.
Comment 5 Lapo Calamandrei 2016-02-03 17:36:06 UTC 
Yeah, it's the margin coming from the buttons and entry, fixed with 207a842bfd5861932738693d444871c4d1173c41